Lint error fixes and checks for future PRs#119
Open
VidushiVashishth wants to merge 3 commits intolint-fixesfrom
Open
Lint error fixes and checks for future PRs#119VidushiVashishth wants to merge 3 commits intolint-fixesfrom
VidushiVashishth wants to merge 3 commits intolint-fixesfrom
Conversation
…omeone makes a local commit and when a new PR is raised against main branch.
VidushiVashishth
force-pushed
the
lint-fixes-2
branch
from
183b1e0 to
bdb951a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is incremental on top of #118. It fixes more functional lint errors (variable names, removes unused variables and commented code, etc). At the point of this PR all pre-existing lint errors have been fixed:
This change also adds configuration to ensure lint checks run whenever someone commits new code changes to this repo locally as well as when one raises a PR. The configuration will not allow code merging unless the errors are addressed or suppressed.