Skip to content

Refactor: break down DeploySmartContract into smaller methods to improve readability #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gldeng wants to merge 1 commit into
base: feature/deterministic-address
Choose a base branch
from
+175 −78

refactor: break down DeploySmartContract into smaller methods to impr…

7c6d5d6
Select commit
Loading
Failed to load commit list.
Open

Refactor: break down DeploySmartContract into smaller methods to improve readability #3448

refactor: break down DeploySmartContract into smaller methods to impr…
7c6d5d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 1, 2026 in 1s

81.25% (-9.48%) compared to a705e46

View this Pull Request on Codecov

81.25% (-9.48%) compared to a705e46

Details

Codecov Report

❌ Patch coverage is 74.38017% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.25%. Comparing base (a705e46) to head (7c6d5d6).

Files with missing lines Patch % Lines
contract/AElf.Contracts.Genesis/Extensions.cs 77.02% 17 Missing ⚠️
...ntract/AElf.Contracts.Genesis/BasicContractZero.cs 47.61% 11 Missing ⚠️
...AElf.Contracts.Genesis/BasicContractZero_Helper.cs 88.46% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a705e46) and HEAD (7c6d5d6). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (a705e46) HEAD (7c6d5d6)
17 12
Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature/deterministic-address    #3448      +/-   ##
=================================================================
- Coverage                          90.72%   81.25%   -9.48%     
=================================================================
  Files                                663      664       +1     
  Lines                              25388    25444      +56     
  Branches                            2280     2282       +2     
=================================================================
- Hits                               23033    20674    -2359     
- Misses                              2239     4607    +2368     
- Partials                             116      163      +47
Files with missing lines Coverage Δ
...AElf.Contracts.Genesis/BasicContractZero_Helper.cs 40.00% <88.46%> (-57.03%) ⬇️
...ntract/AElf.Contracts.Genesis/BasicContractZero.cs 22.25% <47.61%> (-61.73%) ⬇️
contract/AElf.Contracts.Genesis/Extensions.cs 77.02% <77.02%> (ø)

... and 125 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov