Fix wandb logging on rank>0 and add eval debug instrumentation#1391
Open
ilyes319 wants to merge 1 commit intoACEsuit:mainfrom
Open
Fix wandb logging on rank>0 and add eval debug instrumentation#1391ilyes319 wants to merge 1 commit intoACEsuit:mainfrom
ilyes319 wants to merge 1 commit intoACEsuit:mainfrom
Conversation
- Guard wandb logging to rank==0 only in distributed training - Clean up process group on dry_run exit - Add MACE_EVAL_DEBUG_INTERVAL env var for evaluation progress logging Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rank==0only in distributed training to prevent duplicate/erroring log calls on non-primary ranksdry_runexitMACE_EVAL_DEBUG_INTERVALenv var for evaluation progress logging during long validation runsFiles changed
mace/cli/run_train.py-- wandb rank guard and dry_run cleanupmace/tools/train.py-- eval debug interval loggingTest plan
Made with Cursor