Conversation
215e7ee to
1f8cad9
Compare
444f50f to
6e0bf9f
Compare
ca23b78 to
a911803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Godot 4.0 migration
This is the pull request where I would explain the status of the Godot 4.0 port. This port is a full rewrite of the original plugin.
Main goals
Reduce the number of exposed classes
In the previous version, each JSON property was exposed as a named class, which could bloat the autocomplete features of the Godot editor. In this migration, the main objective was to reduce them to just two:
JSONConfigFile: receives a file path and parses it as a JSON.JSONSchema: represents the structure of the JSON data.Simplify the API
This is a code example from version 1.0.0:
In 2.0.0, it would look like this:
Make it similar to Godot's JSON API
I would try to make
JSONConfigFileas similar toJSONas possible.Tasks
In order of priority:
JSONConfigFile'sparsemethod for it to receive the schema.parse_path.