Skip to content

Resolve warning and errors found by latest Google Closure Compiler#3

Open
fiskus wants to merge 2 commits into4u:masterfrom
fiskus:f/prepare_for_closure_v20161024.1.0
Open

Resolve warning and errors found by latest Google Closure Compiler#3
fiskus wants to merge 2 commits into4u:masterfrom
fiskus:f/prepare_for_closure_v20161024.1.0

Conversation

@fiskus
Copy link
Copy Markdown

@fiskus fiskus commented Dec 1, 2016

Resolved following issues:

  1. Seems like mistyping:
npf/source/npf/pages/request.js:42: WARNING - Variable referenced before declaration: options
  var options = options ? goog.object.clone(this.options) : null;
                ^
  1. Google Closure wants {string} for nativeElement.getElementsByTagName, but {enum} for goog.dom.getElementsByTagName:
npf/source/npf/user_agent/css.js:1260: ERROR - actual parameter 1 of Element.prototype.getElementsByTagName does not match formal parameter
found   : goog.dom.TagName<HTMLDivElement>
required: string
        var elems = elem.getElementsByTagName(goog.dom.TagName.DIV);
                                              ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant