From 2183a0efcce6fc83565045937622491139a00c1d Mon Sep 17 00:00:00 2001
From: oniani1 <nonia16@freeuni.edu.ge>
Date: Mon, 23 Mar 2026 23:16:31 +0400
Subject: [PATCH] fix: exclude aggregates and window functions from search path
 lint

The function_search_path_mutable lint flags aggregates and window
functions even though PostgreSQL rejects setting search_path on them.
Filter these out via prokind.

Fixes #139
---
 lints/0011_function_search_path_mutable.sql   |  1 +
 splinter.sql                                  |  1 +
 .../0011_function_search_path_mutable.out     | 19 +++++++++++++++++++
 .../sql/0011_function_search_path_mutable.sql | 16 ++++++++++++++++
 4 files changed, 37 insertions(+)

diff --git a/lints/0011_function_search_path_mutable.sql b/lints/0011_function_search_path_mutable.sql
index d062e42..fe02536 100644
--- a/lints/0011_function_search_path_mutable.sql
+++ b/lints/0011_function_search_path_mutable.sql
@@ -36,6 +36,7 @@ where
         '_timescaledb_cache', '_timescaledb_catalog', '_timescaledb_config', '_timescaledb_internal', 'auth', 'cron', 'extensions', 'graphql', 'graphql_public', 'information_schema', 'net', 'pgmq', 'pgroonga', 'pgsodium', 'pgsodium_masks', 'pgtle', 'pgbouncer', 'pg_catalog', 'pgtle', 'realtime', 'repack', 'storage', 'supabase_functions', 'supabase_migrations', 'tiger', 'topology', 'vault'
     )
     and dep.objid is null -- exclude functions owned by extensions
+    and p.prokind not in ('a', 'w') -- exclude aggregates and window functions
     -- Search path not set
     and not exists (
         select 1
diff --git a/splinter.sql b/splinter.sql
index 14cba60..843b0ae 100644
--- a/splinter.sql
+++ b/splinter.sql
@@ -662,6 +662,7 @@ where
         '_timescaledb_cache', '_timescaledb_catalog', '_timescaledb_config', '_timescaledb_internal', 'auth', 'cron', 'extensions', 'graphql', 'graphql_public', 'information_schema', 'net', 'pgmq', 'pgroonga', 'pgsodium', 'pgsodium_masks', 'pgtle', 'pgbouncer', 'pg_catalog', 'pgtle', 'realtime', 'repack', 'storage', 'supabase_functions', 'supabase_migrations', 'tiger', 'topology', 'vault'
     )
     and dep.objid is null -- exclude functions owned by extensions
+    and p.prokind not in ('a', 'w') -- exclude aggregates and window functions
     -- Search path not set
     and not exists (
         select 1
diff --git a/test/expected/0011_function_search_path_mutable.out b/test/expected/0011_function_search_path_mutable.out
index b24c556..06a4e24 100644
--- a/test/expected/0011_function_search_path_mutable.out
+++ b/test/expected/0011_function_search_path_mutable.out
@@ -45,6 +45,25 @@ begin;
   select * from lint."0011_function_search_path_mutable";
  name | title | level | facing | categories | description | detail | remediation | metadata | cache_key 
 ------+-------+-------+--------+------------+-------------+--------+-------------+----------+-----------
+(0 rows)
+
+  -- Create an aggregate function (should not be flagged)
+  create function public.mysum_state(state integer, val integer)
+    returns integer
+    language sql
+    set search_path = ''
+  as $$
+    select state + val;
+  $$;
+  create aggregate public.mysum(integer) (
+    sfunc = public.mysum_state,
+    stype = integer,
+    initcond = '0'
+  );
+  -- 0 issues: aggregate is excluded, state function has search_path set
+  select * from lint."0011_function_search_path_mutable";
+ name | title | level | facing | categories | description | detail | remediation | metadata | cache_key 
+------+-------+-------+--------+------------+-------------+--------+-------------+----------+-----------
 (0 rows)
 
 rollback;
diff --git a/test/sql/0011_function_search_path_mutable.sql b/test/sql/0011_function_search_path_mutable.sql
index a727fce..65f33c9 100644
--- a/test/sql/0011_function_search_path_mutable.sql
+++ b/test/sql/0011_function_search_path_mutable.sql
@@ -38,6 +38,22 @@ begin;
   -- 1 issue
   select * from lint."0011_function_search_path_mutable";
 
+  -- Create an aggregate function (should not be flagged)
+  create function public.mysum_state(state integer, val integer)
+    returns integer
+    language sql
+    set search_path = ''
+  as $$
+    select state + val;
+  $$;
 
+  create aggregate public.mysum(integer) (
+    sfunc = public.mysum_state,
+    stype = integer,
+    initcond = '0'
+  );
+
+  -- 0 issues: aggregate is excluded, state function has search_path set
+  select * from lint."0011_function_search_path_mutable";
 
 rollback;