Why not fork official node-addon-api?

[liangqi]

I have seen the directory structure is totally different than the official node-addon-api at least.

And how did this project start? Which release or sha1 of the official node-addon-api is the base? Thanks.

https://github.com/nodejs/node-addon-api

[richerfu]

Our code is forked from node-addon-api. And we followed the node-addon-api license in license.

node-addon-api for OpenHarmony/HarmonyNext.
We've made some Harmony-specific adaptations based on node-addon-api, with the aim of providing the same development experience on the Harmony platform.

Why not fork directly?

node-addon-api is a header only project. We just need to import header files that can merge main branch code simplily

How to use it?

See usage

[liangqi]

So update from upstream: copy *.h from https://github.com/nodejs/node-addon-api to include folder?

BTW, if this project is for ohos, was it included in OpenHarmony or HarmonyOS sdk in the future? or will be?

[liangqi]

Which patch(es) for those headers? kind of not upstreamed yet. Do you have materials for those patch(es)? requirements and test code, thanks.

[richerfu]

Include in SDK

No, this is an unoffical project. They have their own DSL to generate N-API bridge.

Difference

https://developer.huawei.com/consumer/cn/doc/harmonyos-references/napi#%E5%B7%B2%E5%AF%BC%E5%87%BA%E7%AC%A6%E5%8F%B7%E5%88%97%E8%A1%A8%E4%B8%8E%E6%A0%87%E5%87%86%E5%BA%93%E5%AF%B9%E5%BA%94%E7%AC%A6%E5%8F%B7%E7%9A%84%E5%B7%AE%E5%BC%82

[richerfu]

Which patch(es) for those headers? kind of not upstreamed yet. Do you have materials for those patch(es)? requirements and test code, thanks.

I didnt save them :(

[richerfu]

You gave me a great idea. We can import upstream directly,and using git patch to manage diff. And then publish them to ohpm

[liangqi]

It looks like only two changes for napi.h, https://github.com/richerfu/node-addon-api-ohos/commits/main/include/napi.h .

[liangqi]

I would like to have two repos, one for the fork of node-addon-api, another for the ohpm(OpenHarmony Package Manager).