Incorporate navbar variations from `qbreader/artwork`

[skysomorphic]

it would look awesome. i rest my case.

Proposed features

• Some kind of system for for changes to the navbar logo to be easily made during cultural events or celebrations, similar to Google Doodles. Probably best implemented through common js/compiled react component loaded by all pages under client/.
• Opt-in for the more silly variations or a "permanent april fools" option
• Include qbreader/artwork as a git submodule, or GET from https://raw.githubusercontent.com/qbreader/artwork/

[geoffrey-wu]

I'd prefer not to use commonJS, since the rest of the project uses ES modules. React is fine but maybe seems overkill, you could probably do it with vanilla JS? template engines are also an option (again probably overkill but could also be useful more broadly to reduce redundancy in the HTML)

[skysomorphic]

Whoops, I meant common js as in a shared piece of code that is loaded by everything not the module standard lol.

[geoffrey-wu]

Ah that makes sense, client/script.js is loaded on every page so that's probably a good place to put it.

[skysomorphic]

Alright now that I'm starting work on this again, I'm making the decision to include artwork/navbar as a git submodule, as opposed to fetching the content from github. The former option is just more convenient and simple to implement compared to the need for a third party api. The main downside to this is that git submodules do not automatically get cloned, and any contributor working on the repo will need to keep that in mind if they wish to work on anything related to this feature.

This also means that git clone --recurse-submodules must be specified when deploying to production.

[geoffrey-wu]

are there no better options like publishing to a package manager or getting from github? I've heard horror stories about gut submodules (like you can't rm -r them) and also it would increase developer complexity (but if you've used submodules successfully before I'm more inclined to use them)

[geoffrey-wu]

I also don't really see what's wrong with directly including the artwork in thjs repository, given that the artwork is primarily being used on this website.

[VillainsRule]

submodules are hell + hard as fuck to understand

[skysomorphic]

actually yeah including the artwork in this repo works fine, my original reasoning for putting all the art in its own repo was so that the commit histories would be kept separate as i didnt feel a server restart is necessary when stuff gets pushed.

[VillainsRule]

qbreader shouldn't need a server restart when things get pushed, but that's a different issue
i (personally) don't like how qbreader runs in terms of like everything, i think it could be a lot faster and just improve a lot
probably just me though, i don't think any of us have time to rewrite server logic in something like Bun (although i would certainly help if any brave soul decides to rewrite)

[geoffrey-wu]

I can change the server restart thing if desired, but I don't think it's an issue so far.

I would like some more explanation before switching the runtime to bun since performance doesn't seem to be an issue? This seems like one of those things that developers care about much more than players (again I could be wrong but I've personally never had an issue with performance either).