From e7980733ad7f1b326dcb522026beef5bac4c971b Mon Sep 17 00:00:00 2001
From: mbressy <bressy.marie@gmail.com>
Date: Fri, 27 Mar 2026 10:48:51 +0000
Subject: [PATCH 1/2] show consumed credits in read-only

---
 inc/ticket.class.php             | 22 ++++++++++++----------
 templates/tickets/form.html.twig | 30 +++++++++++++++++++++---------
 2 files changed, 33 insertions(+), 19 deletions(-)

diff --git a/inc/ticket.class.php b/inc/ticket.class.php
index 65bfcdf..8d0a5d3 100644
--- a/inc/ticket.class.php
+++ b/inc/ticket.class.php
@@ -220,16 +220,18 @@ public static function showForTicket(Ticket $ticket)
 
         $entries = [];
 
-        if ($number && $canedit) {
-            $massiveactionparams = [
-                'num_displayed'    => min($number, $_SESSION['glpilist_limit']),
-                'container'        => 'mass' . self::class . $rand,
-                'itemtype'         => PluginCreditTicket::class,
-                'specific_actions' => [
-                    'update'    => _x('button', 'Update'),
-                    'purge'     => _x('button', 'Delete permanently'),
-                ],
-            ];
+        if ($number) {
+            if ($canedit) {
+                $massiveactionparams = [
+                    'num_displayed'    => min($number, $_SESSION['glpilist_limit']),
+                    'container'        => 'mass' . self::class . $rand,
+                    'itemtype'         => PluginCreditTicket::class,
+                    'specific_actions' => [
+                        'update'    => _x('button', 'Update'),
+                        'purge'     => _x('button', 'Delete permanently'),
+                    ],
+                ];
+            }
             foreach (self::getAllForTicket($ID) as $data) {
                 $credit_entity = new PluginCreditEntity();
                 $credit_entity->getFromDB($data['plugin_credit_entities_id']);
diff --git a/templates/tickets/form.html.twig b/templates/tickets/form.html.twig
index b9a3ac3..70fc54b 100644
--- a/templates/tickets/form.html.twig
+++ b/templates/tickets/form.html.twig
@@ -48,7 +48,7 @@
                         {
                             'entity': entity_id,
                             'condition': conditions,
-                            'on_change': 'getQuantityRemainingForm(this.value);',
+                            'on_change': 'getQuantityRemainingForm' ~ rand ~ '(this.value, this);',
                             'field_class': 'col-4 col-sm-4',
                         }
                     ) }}
@@ -69,15 +69,27 @@
                     ) }}
 
                     <script>
-                        function getQuantityRemainingForm(val) {
-                            var formblock = document.querySelector('.formblock');
-                            var quantity = formblock.querySelector('[id*="plugin_credit_quantity"]');
-                            var quantity_label = formblock.querySelector('[for*="plugin_credit_quantity"]');
+                        function getQuantityRemainingForm{{ rand }}(val, source) {
+                            var form = source ? source.closest('form') : document.getElementById('creditentity_form{{ rand }}');
+                            if (!form) {
+                                return;
+                            }
+
+                            var quantity = form.querySelector('[id*="plugin_credit_quantity"]');
+                            var quantity_label = form.querySelector('[for*="plugin_credit_quantity"]');
+                            if (!quantity || !quantity_label) {
+                                return;
+                            }
+
+                            var form_help = quantity_label.querySelector('span.form-help');
+                            if (!form_help) {
+                                return;
+                            }
 
                             if (val == 0) {
                                 quantity.value = 0;
-                                quantity_label.querySelector('span.form-help').setAttribute('data-bs-title', __('Maximum consumable quantity', 'credit') + ' : 0 ');
-                                quantity_label.querySelector('span.form-help').setAttribute('data-bs-content', __('Maximum consumable quantity', 'credit') + ' : 0 ');
+                                form_help.setAttribute('data-bs-title', __('Maximum consumable quantity', 'credit') + ' : 0 ');
+                                form_help.setAttribute('data-bs-content', __('Maximum consumable quantity', 'credit') + ' : 0 ');
                             } else {
                                 $.ajax({
                                     type: 'POST',
@@ -88,8 +100,8 @@
                                 }).done(function (data) {
                                     quantity.max = data;
                                     quantity.value = 0;
-                                    quantity_label.querySelector('span.form-help').setAttribute('data-bs-title', __('Maximum consumable quantity', 'credit') + ' : <b>' + data);
-                                    quantity_label.querySelector('span.form-help').setAttribute('data-bs-content', __('Maximum consumable quantity', 'credit') + ' : <b>' + data);
+                                    form_help.setAttribute('data-bs-title', __('Maximum consumable quantity', 'credit') + ' : <b>' + data);
+                                    form_help.setAttribute('data-bs-content', __('Maximum consumable quantity', 'credit') + ' : <b>' + data);
                                 });
                             }
                         }

From 6548688e6a17a00562e2d7c9749caaabf0c16324 Mon Sep 17 00:00:00 2001
From: mbressy <bressy.marie@gmail.com>
Date: Wed, 8 Apr 2026 08:37:24 +0000
Subject: [PATCH 2/2] show credit vouchers in read-only entity tab

---
 inc/entity.class.php             | 4 ++--
 templates/creditentity.hmtl.twig | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/inc/entity.class.php b/inc/entity.class.php
index d0f1768..726ea6d 100644
--- a/inc/entity.class.php
+++ b/inc/entity.class.php
@@ -167,7 +167,7 @@ public static function showForItemtype(Entity $entity, $itemtype = 'Entity')
 
         $canedit = $itemtype === 'Entity' && $entity->canEdit($ID);
 
-        if ($itemtype === 'Entity') {
+        if ($itemtype === 'Entity' && $canedit) {
             PluginCreditEntityConfig::showEntityConfigForm($entity->getID());
         }
 
@@ -244,7 +244,7 @@ public static function showForItemtype(Entity $entity, $itemtype = 'Entity')
             'itemtype'         => PluginCreditEntity::class,
         ];
 
-        if ($itemtype === 'Entity' && $canedit) {
+        if ($itemtype === 'Entity') {
             TemplateRenderer::getInstance()->display('@credit/creditentity.hmtl.twig', [
                 'form_url'              => self::getFormUrl(),
                 'credittypeclass'       => PluginCreditType::class,
diff --git a/templates/creditentity.hmtl.twig b/templates/creditentity.hmtl.twig
index 93343df..efc143f 100644
--- a/templates/creditentity.hmtl.twig
+++ b/templates/creditentity.hmtl.twig
@@ -30,6 +30,7 @@
 {% import "components/form/fields_macros.html.twig" as fields %}
 
 {% set rand = random() %}
+{% if canedit %}
 <div name="firstbloc" id="firstbloc" class="">
     <form name="creditentity_form{{ rand }}" id="creditentity_form{{ rand }}" method="post" action="{{ form_url }}">
         <input type="hidden" name="_glpi_csrf_token" value="{{ csrf_token() }}" />
@@ -121,6 +122,7 @@
         <div class="hr mt-3 mb-3"></div>
     </form>
 </div>
+{% endif %}
 <div name="secondbloc" id="secondbloc" class="mb-5">
     {% set datatable_params = {
         'is_tab': true,