DePanEstimate and DePan report MT mode for Avisynth+

[realfinder]

seems DePanEstimate and DePan dont report MT mode for Avisynth+, so in case I set SetFilterMTMode("DEFAULT_MT_MODE", 1) I get x264 crash in KERNELBASE.dll with script that has stab3()

[pinterf]

Afaik mode 3 is the suitable setting for them (Serialized), while mode 1 is the highest level MT mode, assumes fully reentrant design, with no global internal states, which is fulfilled only by a subset of filters. Avisynth's default is 2 (MT_MULTI_INSTANCE) which is good for most filters. Anyway, I will check the issue.

[pinterf]

As a side note: never update the global default mode, e.g. to MT_NICE_FILTER (1), let's leave the default on MT_MULTI_INSTANCE. (except source filters which are MT_SERIALIZED by default).
You can still set individual SetFilterMTMode( <filter name>, MT_SERIALIZED) (3) for still problematic, non-MT friendly filters. Being "serialized" does not mean linear access, it just ensures the non-reentrant filter instance call.
Find more info at:
https://avisynthplus.readthedocs.io/en/latest/avisynthdoc/syntax/syntax_internal_functions_multithreading_new.html#setfiltermtmode

[realfinder]

As a side note: never update the global default mode, e.g. to MT_NICE_FILTER (1), let's leave the default on MT_MULTI_INSTANCE.

I did this because there are many new MT friendly filters but they dont report MT mode, like https://github.com/EleonoreMizo/fmtconv/releases and https://github.com/sekrit-twc/EdgeFixer/releases

[realfinder]

the random crashes seems back even with "Serialized" after I did some changes in the encoding script! and now it's x264 and C:\WINDOWS\SYSTEM32\ntdll.dl

so I think maybe because DePanEstimate and DePan also dont has FFTW mt guard at all (not the new Global lock guard since IIRC other plugins by the time do get some FFTW mt guard that at least work in some cases)?

[pinterf]

O.K. it won't hurt then if they get the pre-caution. Could you provide me a script, which randomly though, but crashes? That would also help me in debugging.

[realfinder]

Could you provide me a script, which randomly though, but crashes?

sure

SetFilterMTMode("DEFAULT_MT_MODE", 1)
loadplugin("AVSTP.dll)
LWLibavVideoSource("Main Disc\BDMV\STREAM\00033.m2ts").RequestLinear(clim=100,elim=50)

SRFComb(SpatialDeDotCraw=false)
AnimeIVTC(1,o3025cfr=true).TDecimate(1)
filtering_wob("Convertbits(32).bore_SinglePlane(4,4).Convertbits(8).stab3(mirror=15,fillborder=2,use_inpaintdelogo=true,tstab=true)",6,0,6,0)

convertbits(16)
DeHalo_alpha(darkstr=0.001)

SMDegrain(mfilter=sh_KNLMeansCL(h=1.5,knlm_params=",ocl_x=16,ocl_y=16,ocl_r=16"))

neo_f3kdb(sample_mode=4)

Prefetch()

my plugins https://github.com/realfinder/UniversalPluginsFolders

Edit: it worth mention that if I guard it with RequestLinear like this filtering_wob("Convertbits(32).bore_SinglePlane(4,4).Convertbits(8).RequestLinear(100,clim=200,elim=100).stab3(mirror=15,fillborder=2,use_inpaintdelogo=true,tstab=true)",6,0,6,0).RequestLinear(50,clim=100,elim=50) seems work fine but a bit slower

[pinterf]

Thanks. Downloaded everything, copied all 64 bit stuff.
I got: There is no function named 'SRFComb'.
Neither was I able to found it in meaningful time on the net.

[realfinder]

I got: There is no function named 'SRFComb'.
Neither was I able to found it in meaningful time on the net.

already in https://github.com/realfinder/UniversalPluginsFolders/blob/master/plugins64/26/SRFComb.avsi
use the full folders like this

ClearAutoloadDirs()
AddAutoloadDir("D:\UniversalPluginsFolders\plugins64+", false)
AddAutoloadDir("D:\UniversalPluginsFolders\plugins64", false)

[pinterf]

Thanks, I used the 7z pack, which did not contain it.
Anyway, your script sets NICE_FILTER to every plugin which does not report its MT mode. If you do so, you have to dig and find all such filters that do not like being a NICE_FILTER, and specify their MT mode manually, one-by-one to the probably safe MT_MULTI_INSTANCE mode. Maybe not only Depan and DepanEstimate are anti-NICE filters in that huge wrapper function collection.
So you still got crash even when you told these filters a less-harmful MT mode or serialized one?
PS thanks for the autoload tip, I already forgot about it.

[realfinder]

your script sets NICE_FILTER to every plugin which does not report its MT mode. If you do so, you have to dig and find all such filters that do not like being a NICE_FILTER, and specify their MT mode manually

already did, and even went as this far to Asd-g/AviSynth-DeDot#1

also even without SetFilterMTMode("DEFAULT_MT_MODE", 1) I did get a random crash

[pinterf]

Added Import("d:\UniversalPluginsFolders\plugins64\26\SRFComb.avsi")
But where to find filtering_wob?

[realfinder]

But where to find filtering_wob?

AdvancedDenoising.avsi

[pinterf]

Thanks, using the latest source instead of the .7z archive fixed the initial issues.

A test build is now available here:
https://drive.google.com/file/d/1kvWNojUfyZsqC0b-FY4yIn54HhBntwLy/view?usp=sharing
Please check the readme for the change log.

[realfinder]

A test build is now available

thank you!

but unfortunately still randomly crashing

[pinterf]

Then it was not the root cause. I tested now the MT_MULTI_INSTANCE default mode, and with the old dlls it exited at 2860th frame (almost 8 mins, one run so far), using avsmeter64. At least you cannot force the NICE_FILTER anymore for these new depan DLLs , Their filters have variables in the class and when NICE was active, these internal variables and buffers were written parallelly, overwriting each other's results. Unlike MT_MULTI_INSTANCE which handles the individual internal class variables safely. When a filter's GetFrame is writing back into any variable for the class, then it is not eligible for being NICE_FILTER.