From a7a76cf88cf94e1892131ff2158c868de9efd016 Mon Sep 17 00:00:00 2001 From: inoway46 Date: Sun, 22 Feb 2026 20:47:12 +0900 Subject: [PATCH] test: relax debugger attach sync in tests --- test/parallel/test-debugger-auto-resume.mjs | 2 ++ test/parallel/test-debugger-backtrace.js | 1 + test/parallel/test-debugger-break.js | 1 + test/parallel/test-debugger-clear-breakpoints.js | 3 ++- test/parallel/test-debugger-exceptions.js | 2 +- test/parallel/test-debugger-extract-function-name.mjs | 1 + test/parallel/test-debugger-help.mjs | 1 + test/parallel/test-debugger-object-type-remote-object.js | 1 + test/parallel/test-debugger-preserve-breaks.js | 2 ++ test/parallel/test-debugger-profile.js | 1 + test/parallel/test-debugger-random-port-with-inspect-port.js | 2 +- test/parallel/test-debugger-sb-before-load.js | 1 + test/parallel/test-debugger-watch-validation.js | 3 ++- 13 files changed, 17 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-debugger-auto-resume.mjs b/test/parallel/test-debugger-auto-resume.mjs index f8dbf3be583237..321dddb513726b 100644 --- a/test/parallel/test-debugger-auto-resume.mjs +++ b/test/parallel/test-debugger-auto-resume.mjs @@ -23,7 +23,9 @@ addLibraryPath(process.env); const cli = startCLI([script], [], { env }); + await cli.waitForPrompt(); await cli.waitForInitialBreak(); + await cli.waitForPrompt(); assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 10, diff --git a/test/parallel/test-debugger-backtrace.js b/test/parallel/test-debugger-backtrace.js index c189cb3f5b22e6..71d960b5186b72 100644 --- a/test/parallel/test-debugger-backtrace.js +++ b/test/parallel/test-debugger-backtrace.js @@ -17,6 +17,7 @@ const path = require('path'); async function runTest() { try { + await cli.waitForPrompt(); await cli.waitForInitialBreak(); await cli.waitForPrompt(); await cli.stepCommand('c'); diff --git a/test/parallel/test-debugger-break.js b/test/parallel/test-debugger-break.js index 4da400e4475821..a4a3e5e73d3223 100644 --- a/test/parallel/test-debugger-break.js +++ b/test/parallel/test-debugger-break.js @@ -14,6 +14,7 @@ const script = path.relative(process.cwd(), scriptFullPath); const cli = startCLI([script]); (async () => { + await cli.waitForPrompt(); await cli.waitForInitialBreak(); await cli.waitForPrompt(); assert.deepStrictEqual( diff --git a/test/parallel/test-debugger-clear-breakpoints.js b/test/parallel/test-debugger-clear-breakpoints.js index 91349e105a1160..06f2199a1f15b1 100644 --- a/test/parallel/test-debugger-clear-breakpoints.js +++ b/test/parallel/test-debugger-clear-breakpoints.js @@ -20,7 +20,8 @@ const path = require('path'); throw error; } - return cli.waitForInitialBreak() + return cli.waitForPrompt() + .then(() => cli.waitForInitialBreak()) .then(() => cli.waitForPrompt()) .then(() => cli.command('sb("break.js", 3)')) .then(() => cli.command('sb("break.js", 9)')) diff --git a/test/parallel/test-debugger-exceptions.js b/test/parallel/test-debugger-exceptions.js index 3f75161a6b6e3d..52fc9d48784ce1 100644 --- a/test/parallel/test-debugger-exceptions.js +++ b/test/parallel/test-debugger-exceptions.js @@ -17,8 +17,8 @@ const path = require('path'); (async () => { try { - await cli.waitForInitialBreak(); await cli.waitForPrompt(); + await cli.waitForInitialBreak(); await cli.waitForPrompt(); assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 }); diff --git a/test/parallel/test-debugger-extract-function-name.mjs b/test/parallel/test-debugger-extract-function-name.mjs index a7de32ad4e2cf5..53cc6b47ed74ec 100644 --- a/test/parallel/test-debugger-extract-function-name.mjs +++ b/test/parallel/test-debugger-extract-function-name.mjs @@ -10,6 +10,7 @@ import assert from 'assert'; const cli = startCLI([fixtures.path('debugger', 'three-lines.js')]); try { + await cli.waitForPrompt(); await cli.waitForInitialBreak(); await cli.waitForPrompt(); await cli.command('exec a = function func() {}; a;'); diff --git a/test/parallel/test-debugger-help.mjs b/test/parallel/test-debugger-help.mjs index 1fb710d6280160..08ff874d926c23 100644 --- a/test/parallel/test-debugger-help.mjs +++ b/test/parallel/test-debugger-help.mjs @@ -10,6 +10,7 @@ import assert from 'assert'; const cli = startCLI([fixtures.path('debugger', 'empty.js')]); try { + await cli.waitForPrompt(); await cli.waitForInitialBreak(); await cli.waitForPrompt(); await cli.command('help'); diff --git a/test/parallel/test-debugger-object-type-remote-object.js b/test/parallel/test-debugger-object-type-remote-object.js index 7404eae3963447..892550aa32e310 100644 --- a/test/parallel/test-debugger-object-type-remote-object.js +++ b/test/parallel/test-debugger-object-type-remote-object.js @@ -11,6 +11,7 @@ const assert = require('assert'); const cli = startCLI([fixtures.path('debugger/empty.js')]); (async () => { + await cli.waitForPrompt(); await cli.waitForInitialBreak(); await cli.waitForPrompt(); await cli.command('exec new Date(0)'); diff --git a/test/parallel/test-debugger-preserve-breaks.js b/test/parallel/test-debugger-preserve-breaks.js index 7730039aed71b8..3f0496f2136d10 100644 --- a/test/parallel/test-debugger-preserve-breaks.js +++ b/test/parallel/test-debugger-preserve-breaks.js @@ -29,7 +29,9 @@ const script = path.relative(process.cwd(), scriptFullPath); await cli.stepCommand('c'); // hit line 3 assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 3 }); await cli.command('restart'); + await cli.waitForPrompt(); await cli.waitForInitialBreak(); + await cli.waitForPrompt(); assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 }); await cli.stepCommand('c'); assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 2 }); diff --git a/test/parallel/test-debugger-profile.js b/test/parallel/test-debugger-profile.js index 31f57ee06da65d..b489bea08ad8c6 100644 --- a/test/parallel/test-debugger-profile.js +++ b/test/parallel/test-debugger-profile.js @@ -30,6 +30,7 @@ function delay(ms) { try { (async () => { + await cli.waitForPrompt(); await cli.waitForInitialBreak(); await cli.waitForPrompt(); await cli.command('exec console.profile()'); diff --git a/test/parallel/test-debugger-random-port-with-inspect-port.js b/test/parallel/test-debugger-random-port-with-inspect-port.js index a7e74c0dbae6d6..9256b3cd1d02ca 100644 --- a/test/parallel/test-debugger-random-port-with-inspect-port.js +++ b/test/parallel/test-debugger-random-port-with-inspect-port.js @@ -13,7 +13,7 @@ const script = fixtures.path('debugger', 'three-lines.js'); const cli = startCLI(['--inspect-port=0', script], [], {}, { randomPort: false }); (async () => { - await cli.waitForInitialBreak(); + await cli.waitFor(/Debugger attached\./); await cli.waitForPrompt(); assert.match(cli.output, /debug>/, 'prints a prompt'); assert.match( diff --git a/test/parallel/test-debugger-sb-before-load.js b/test/parallel/test-debugger-sb-before-load.js index e2267156b7420b..f39803536cb439 100644 --- a/test/parallel/test-debugger-sb-before-load.js +++ b/test/parallel/test-debugger-sb-before-load.js @@ -20,6 +20,7 @@ const otherScript = path.relative(process.cwd(), otherScriptFullPath); const cli = startCLI([script]); (async () => { + await cli.waitForPrompt(); await cli.waitForInitialBreak(); await cli.waitForPrompt(); await cli.command('sb("other.js", 2)'); diff --git a/test/parallel/test-debugger-watch-validation.js b/test/parallel/test-debugger-watch-validation.js index 46307c18d55526..0e92d19a748b95 100644 --- a/test/parallel/test-debugger-watch-validation.js +++ b/test/parallel/test-debugger-watch-validation.js @@ -11,7 +11,8 @@ const assert = require('assert'); const cli = startCLI([fixtures.path('debugger/break.js')]); (async () => { - await cli.waitForInitialBreak(); + await cli.waitFor(/Debugger attached\./); + await cli.waitForPrompt(); await cli.command('watch()'); await cli.waitFor(/ERR_INVALID_ARG_TYPE/); assert.match(cli.output, /TypeError \[ERR_INVALID_ARG_TYPE\]: The "expression" argument must be of type string\. Received undefined/);