remove redundant typing import and fix SIM115

Author: ahmedmuhsin

python/packages/azurefunctions/agent_framework_azurefunctions/_serialization.py

@@ -11,7 +11,7 @@
 import logging
 import types
 from dataclasses import asdict, fields, is_dataclass
-from typing import Any, Union, get_args, get_origin
+from typing import Any, Union, get_args, get_origin, get_type_hints
 
 from agent_framework import (
     AgentExecutorRequest,
@@ -169,9 +169,7 @@ def _reconstruct_dataclass_fields(dataclass_type: type, data: dict[str, Any]) ->
 
     # Get type hints for the dataclass
     try:
-        import typing
-
-        type_hints = typing.get_type_hints(dataclass_type)
+        type_hints = get_type_hints(dataclass_type)
     except Exception:
         # Fall back to field annotations if get_type_hints fails
         for f in fields(dataclass_type):

python/packages/azurefunctions/tests/integration_tests/conftest.py

@@ -5,7 +5,6 @@
 This module provides fixtures and configuration for pytest.
 """
 
-import logging
 import subprocess
 import sys
 from collections.abc import Iterator, Mapping
@@ -15,12 +14,10 @@
 import pytest
 import requests
 
-logger = logging.getLogger(__name__)
-
 # Add the integration_tests directory to the path so testutils can be imported
 sys.path.insert(0, str(Path(__file__).parent))
 
-from testutils import (  # noqa: E402
+from testutils import (
     FunctionAppStartupError,
     build_base_url,
     cleanup_function_app,
@@ -93,34 +90,22 @@ class TestSample01SingleAgent:
     max_attempts = 3
     last_error: Exception | None = None
     func_process: subprocess.Popen[Any] | None = None
-    log_file: Any = None
     base_url = ""
     port = 0
 
     for _ in range(max_attempts):
         port = find_available_port()
         base_url = build_base_url(port)
-        func_process, log_file = start_function_app(sample_path, port)
+        func_process = start_function_app(sample_path, port)
 
         try:
             wait_for_function_app_ready(func_process, port)
             last_error = None
             break
         except FunctionAppStartupError as exc:
-            log_file.seek(0)
-            logs = log_file.read().decode("utf-8", errors="replace")
-            last_error = FunctionAppStartupError(f"{exc}\nLogs:\n{logs}")
+            last_error = exc
             cleanup_function_app(func_process)
-            log_file.close()
             func_process = None
-            log_file = None
-        except BaseException:
-            # Capture logs on timeout or other interruptions
-            if log_file:
-                log_file.seek(0)
-                logs = log_file.read().decode("utf-8", errors="replace")
-                logger.info("[Startup Interrupted] Partial Logs:\n%s", logs)
-            raise
 
     if func_process is None:
         error_message = f"Function app failed to start after {max_attempts} attempt(s)."
@@ -133,12 +118,6 @@ class TestSample01SingleAgent:
     finally:
         if func_process is not None:
             cleanup_function_app(func_process)
-        if log_file is not None:
-            log_file.seek(0)
-            logger.info("\n=== Function App Logs ===")
-            logger.info(log_file.read().decode("utf-8", errors="replace"))
-            logger.info("=========================")
-            log_file.close()
 
 
 @pytest.fixture(scope="module")

python/packages/azurefunctions/tests/integration_tests/testutils.py

@@ -9,7 +9,6 @@
 import socket
 import subprocess
 import sys
-import tempfile
 import time
 import uuid
 from contextlib import suppress
@@ -295,44 +294,30 @@ def load_and_validate_env() -> None:
         )
 
 
-def start_function_app(sample_path: Path, port: int) -> tuple[subprocess.Popen, Any]:
+def start_function_app(sample_path: Path, port: int) -> subprocess.Popen:
     """
     Start a function app in the specified sample directory.
 
-    Returns the subprocess.Popen object and the log file handle.
+    Returns the subprocess.Popen object for the running process.
     """
     env = os.environ.copy()
     # Use a unique TASKHUB_NAME for each test run to ensure test isolation.
     # This prevents conflicts between parallel or repeated test runs, as Durable Functions
     # use the task hub name to separate orchestration state.
     env["TASKHUB_NAME"] = f"test{uuid.uuid4().hex[:8]}"
 
-    # The log_file handle is returned to the caller and must remain open beyond this function,
-    # so we intentionally do not use a context manager here.  # noqa: SIM115
-    log_file = tempfile.TemporaryFile()
-
     # On Windows, use CREATE_NEW_PROCESS_GROUP to allow proper termination
     # shell=True only on Windows to handle PATH resolution
     if sys.platform == "win32":
-        process = subprocess.Popen(
-            ["func", "start", "--verbose", "--port", str(port)],
+        return subprocess.Popen(
+            ["func", "start", "--port", str(port)],
             cwd=str(sample_path),
             creationflags=subprocess.CREATE_NEW_PROCESS_GROUP,
             shell=True,
             env=env,
-            stdout=log_file,
-            stderr=subprocess.STDOUT,
         )
-        return process, log_file
     # On Unix, don't use shell=True to avoid shell wrapper issues
-    process = subprocess.Popen(
-        ["func", "start", "--verbose", "--port", str(port)],
-        cwd=str(sample_path),
-        env=env,
-        stdout=log_file,
-        stderr=subprocess.STDOUT,
-    )
-    return process, log_file
+    return subprocess.Popen(["func", "start", "--port", str(port)], cwd=str(sample_path), env=env)
 
 
 def wait_for_function_app_ready(func_process: subprocess.Popen, port: int, max_wait: int = 60) -> None: