From d5a88cb8967e76712e1d6a9afa03cc54984f96d1 Mon Sep 17 00:00:00 2001 From: Haiyang Xu Date: Tue, 17 Feb 2026 13:07:54 -0800 Subject: [PATCH 1/3] public use betafilter --- diskann-providers/src/model/graph/provider/layers/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/diskann-providers/src/model/graph/provider/layers/mod.rs b/diskann-providers/src/model/graph/provider/layers/mod.rs index 5d6312767..6bf6e6cad 100644 --- a/diskann-providers/src/model/graph/provider/layers/mod.rs +++ b/diskann-providers/src/model/graph/provider/layers/mod.rs @@ -11,4 +11,4 @@ //! * [`BetaFilter`] mod betafilter; -pub use betafilter::BetaFilter; +pub use betafilter::{BetaAccessor, BetaComputer, BetaFilter, Unwrap}; From 48d9643149c6ff1153b83510790a448ab392d575 Mon Sep 17 00:00:00 2001 From: Haiyang <3389245+hailangx@users.noreply.github.com> Date: Sun, 22 Feb 2026 15:30:02 -0800 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- diskann-providers/src/model/graph/provider/layers/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/diskann-providers/src/model/graph/provider/layers/mod.rs b/diskann-providers/src/model/graph/provider/layers/mod.rs index 6bf6e6cad..8b2b0c6a5 100644 --- a/diskann-providers/src/model/graph/provider/layers/mod.rs +++ b/diskann-providers/src/model/graph/provider/layers/mod.rs @@ -11,4 +11,4 @@ //! * [`BetaFilter`] mod betafilter; -pub use betafilter::{BetaAccessor, BetaComputer, BetaFilter, Unwrap}; +pub use betafilter::{BetaAccessor, BetaComputer, BetaFilter, Unwrap as BetaFilterUnwrap}; From 44fd21092b1a0a4de492049517fb3696c3d6a9c6 Mon Sep 17 00:00:00 2001 From: Haiyang Xu Date: Mon, 23 Feb 2026 10:01:52 -0800 Subject: [PATCH 3/3] just make the SearchStrategy generic over ouput --- .../src/model/graph/provider/layers/betafilter.rs | 5 +++-- diskann-providers/src/model/graph/provider/layers/mod.rs | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/diskann-providers/src/model/graph/provider/layers/betafilter.rs b/diskann-providers/src/model/graph/provider/layers/betafilter.rs index 47ce6350b..edd1e3139 100644 --- a/diskann-providers/src/model/graph/provider/layers/betafilter.rs +++ b/diskann-providers/src/model/graph/provider/layers/betafilter.rs @@ -112,12 +112,13 @@ where /// /// The [`BetaComputer`] then uses this ID to consult the filter predicate and adjust the /// distance accordingly. -impl SearchStrategy for BetaFilter +impl SearchStrategy for BetaFilter where T: ?Sized, I: VectorId, + O: Send, Provider: DataProvider, - Strategy: SearchStrategy, + Strategy: SearchStrategy, { /// An accessor that returns the ID in addition to the element yielded by the inner /// accessor. diff --git a/diskann-providers/src/model/graph/provider/layers/mod.rs b/diskann-providers/src/model/graph/provider/layers/mod.rs index 8b2b0c6a5..5d6312767 100644 --- a/diskann-providers/src/model/graph/provider/layers/mod.rs +++ b/diskann-providers/src/model/graph/provider/layers/mod.rs @@ -11,4 +11,4 @@ //! * [`BetaFilter`] mod betafilter; -pub use betafilter::{BetaAccessor, BetaComputer, BetaFilter, Unwrap as BetaFilterUnwrap}; +pub use betafilter::BetaFilter;