From 04566da08bbb9c32422df2cb2a9fd91283509059 Mon Sep 17 00:00:00 2001 From: John Stark Date: Mon, 7 Mar 2016 16:34:16 -0700 Subject: [PATCH 1/2] Fix for 0.9 producer Adding a space for DefaultClientId was required for kafkanet to work with Kafka 0.9 https://issues.apache.org/jira/browse/KAFKA-3088 --- src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs b/src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs index 8c02c91..290c999 100644 --- a/src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs +++ b/src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs @@ -35,7 +35,7 @@ public class SyncProducerConfiguration : ISyncProducerConfigShared public const int DefaultCorrelationId = -1; - public const string DefaultClientId = ""; + public const string DefaultClientId = " "; public const short DefaultRequiredAcks = 0; From f92952d917437ee913e80557fb88e6466ed04ded Mon Sep 17 00:00:00 2001 From: John Stark Date: Mon, 7 Mar 2016 16:35:57 -0700 Subject: [PATCH 2/2] comment with explanation Added comment so no one is tempted to remove space at a later point --- src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs b/src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs index 290c999..f186f80 100644 --- a/src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs +++ b/src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs @@ -35,7 +35,7 @@ public class SyncProducerConfiguration : ISyncProducerConfigShared public const int DefaultCorrelationId = -1; - public const string DefaultClientId = " "; + public const string DefaultClientId = " "; //NOTE: Space is required for 0.9 producer https://issues.apache.org/jira/browse/KAFKA-3088 public const short DefaultRequiredAcks = 0;