From 24fc90653b9670ae68a414d917e3d2cd1fa0420f Mon Sep 17 00:00:00 2001 From: Chandra Sirimala Date: Fri, 20 Feb 2026 09:32:40 +0000 Subject: [PATCH 1/2] fix: pass token correctly, '&' instead of ',' --- google/cloud/storage/asyncio/async_appendable_object_writer.py | 2 +- google/cloud/storage/asyncio/async_read_object_stream.py | 2 +- google/cloud/storage/asyncio/async_write_object_stream.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/google/cloud/storage/asyncio/async_appendable_object_writer.py b/google/cloud/storage/asyncio/async_appendable_object_writer.py index a7544c203..56b3a0ec5 100644 --- a/google/cloud/storage/asyncio/async_appendable_object_writer.py +++ b/google/cloud/storage/asyncio/async_appendable_object_writer.py @@ -310,7 +310,7 @@ async def _do_open(): ) await self.write_obj_stream.open( - metadata=current_metadata if metadata else None + metadata=current_metadata if current_metadata else None ) if self.write_obj_stream.generation_number: diff --git a/google/cloud/storage/asyncio/async_read_object_stream.py b/google/cloud/storage/asyncio/async_read_object_stream.py index d456f16cc..b6cf69901 100644 --- a/google/cloud/storage/asyncio/async_read_object_stream.py +++ b/google/cloud/storage/asyncio/async_read_object_stream.py @@ -115,7 +115,7 @@ async def open(self, metadata: Optional[List[Tuple[str, str]]] = None) -> None: other_metadata.append((key, value)) current_metadata = other_metadata - current_metadata.append(("x-goog-request-params", ",".join(request_params))) + current_metadata.append(("x-goog-request-params", "&".join(reversed(request_params)))) self.socket_like_rpc = AsyncBidiRpc( self.rpc, diff --git a/google/cloud/storage/asyncio/async_write_object_stream.py b/google/cloud/storage/asyncio/async_write_object_stream.py index de4be3820..4729cfd20 100644 --- a/google/cloud/storage/asyncio/async_write_object_stream.py +++ b/google/cloud/storage/asyncio/async_write_object_stream.py @@ -145,7 +145,7 @@ async def open(self, metadata: Optional[List[Tuple[str, str]]] = None) -> None: else: final_metadata.append((key, value)) - final_metadata.append(("x-goog-request-params", ",".join(request_param_values))) + final_metadata.append(("x-goog-request-params", "&".join(request_param_values))) self.socket_like_rpc = AsyncBidiRpc( self.rpc, From dece2f7eaa74db8c390baaa8994899698a6b7378 Mon Sep 17 00:00:00 2001 From: Chandra Shekhar Sirimala Date: Fri, 20 Feb 2026 15:14:17 +0530 Subject: [PATCH 2/2] remove reversed reversed not needed Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- google/cloud/storage/asyncio/async_read_object_stream.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google/cloud/storage/asyncio/async_read_object_stream.py b/google/cloud/storage/asyncio/async_read_object_stream.py index b6cf69901..bde6c1651 100644 --- a/google/cloud/storage/asyncio/async_read_object_stream.py +++ b/google/cloud/storage/asyncio/async_read_object_stream.py @@ -115,7 +115,7 @@ async def open(self, metadata: Optional[List[Tuple[str, str]]] = None) -> None: other_metadata.append((key, value)) current_metadata = other_metadata - current_metadata.append(("x-goog-request-params", "&".join(reversed(request_params)))) + current_metadata.append(("x-goog-request-params", "&".join(request_params))) self.socket_like_rpc = AsyncBidiRpc( self.rpc,