Fix changesets workflow - Remove duplicate tag creation and update job dependencies (#13592)

* Initial plan

* Fix changeset script - remove duplicate tag creation

The changeset.js script was trying to create a git tag that already exists,
causing the GitHub Actions workflow to fail. The workflow's release job creates
the tag first, then the changesets job calls changeset.js which tried to create
the same tag again.

Changes:
- Removed tag creation (git tag -a) from changeset.js
- Removed tag push (git push origin <tag>) from changeset.js
- Updated error recovery instructions to not mention tag operations
- Added documentation clarifying the script expects tags to be pre-created

The script now only updates CHANGELOG.md, deletes changeset files, commits
changes, and pushes to main - no tag operations.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Update changesets job to depend on agent job

The changesets job now runs after the agent job completes, ensuring
release highlights are generated before the CHANGELOG is updated.

Before: agent -> depends on changesets
After: changesets -> depends on agent

This allows the agent to generate release highlights first, then the
CHANGELOG can be updated with the full context.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>

Author: Copilot

.github/workflows/release.lock.yml

@@ -303,7 +303,7 @@ jobs:
           provenance: mode=max
 
   changesets:
-    needs: ["activation", "config", "release"]
+    needs: ["activation", "config", "release", "agent"]
     runs-on: ubuntu-latest
     permissions:
       contents: write

.github/workflows/release.md

@@ -9,6 +9,10 @@
  *
  * Example:
  *   node changeset.js release v1.2.3 --yes
+ *
+ * Note: This script does NOT create or push git tags. Tags should be created by the caller
+ * (e.g., the GitHub Actions workflow) before running this script. This script only updates
+ * CHANGELOG.md, deletes changeset files, commits the changes, and pushes to the main branch.
  */
 
 const fs = require("fs");
@@ -492,21 +496,13 @@ async function runRelease(versionTag, skipConfirmation = false) {
     console.log(formatInfoMessage("Committing changes..."));
     execSync(`git commit -m "Release ${versionString}"`, { encoding: "utf8" });
 
-    // Create tag
-    console.log(formatInfoMessage("Creating tag..."));
-    execSync(`git tag -a ${versionString} -m "Release ${versionString}"`, { encoding: "utf8" });
-
     // Push commit to remote
     console.log(formatInfoMessage("Pushing commit..."));
     execSync("git push", { encoding: "utf8" });
 
-    // Push tag
-    console.log(formatInfoMessage("Pushing tag..."));
-    execSync(`git push origin ${versionString}`, { encoding: "utf8" });
-
     console.log("");
     console.log(formatSuccessMessage(`Successfully released ${versionString}`));
-    console.log(formatSuccessMessage("Commit and tag pushed to remote"));
+    console.log(formatSuccessMessage("Commit pushed to remote"));
   } catch (error) {
     console.log("");
     console.error(formatErrorMessage("Git operation failed: " + error.message));
@@ -518,9 +514,7 @@ async function runRelease(versionTag, skipConfirmation = false) {
       console.log(`  git add CHANGELOG.md`);
     }
     console.log(`  git commit -m "Release ${versionString}"`);
-    console.log(`  git tag -a ${versionString} -m "Release ${versionString}"`);
     console.log(`  git push`);
-    console.log(`  git push origin ${versionString}`);
     process.exit(1);
   }
 }