fix: remove setStatus(OK) calls to comply with OTel spec#135
Merged
metcoder95 merged 1 commit intofastify:mainfrom Mar 4, 2026
Merged
fix: remove setStatus(OK) calls to comply with OTel spec#135metcoder95 merged 1 commit intofastify:mainfrom
metcoder95 merged 1 commit intofastify:mainfrom
Conversation
Signed-off-by: h6o <48004352+newbee1939@users.noreply.github.com>
metcoder95
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126
Remove
setStatus(OK)calls fromfinalizeResponseSpanHookandfinalizeNotFoundSpanHookto comply with the OTel spec, which states instrumentation libraries should leave span status asUnsetunless there is an error.SpanStatusCode.ERRORfor 5xx responsesreply.statusCodeinstead of hardcoded404infinalizeNotFoundSpanHookChecklist
npm run test && npm run benchmark --if-presentand the Code of conduct