dotnet-svcutil tool sometimes makes public types when specifying /internal

[mconnew]

I've attached a repro for the problem. In an empty console app with the wsdl from the zip file saved to the project root, run the following command:

dotnet-svcutil MinimalRepo.wsdl -d MinimalRepro --internal

This will generate a file MinimalRepro\Reference.cs which has the type Data which has been created as a public type and not internal as specified. This has a property called DataRecords which is of type ArrayOfXElement which has been generated as an internal type. This causes a compilation error as a public type has a public member which references an internal type, which is invalid.

MinimalRepo.zip

[mconnew]

@imcarolwang, can you please take a look and see if you can root cause this. This bug also exists on .NET Framework, although there it doesn't cause a compilation error as the ArrayOfXElement isn't created as that property maps to DataSet. But the Data type is still generated public instead of internal. It only fails on .NET because DataSet isn't properly supported so it generates an extra type which is (correctly) internal.