Skip to content

Flaky test - github.com/docker/buildx/dap #3695

@buckaroogeek

Description

@buckaroogeek

Contributing guidelines

I've found a bug and checked that ...

  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

When building buildx v0.32.0 on Fedora Rawhide (go 1.26) I am seeing a flaky test result. In the go test section of the output on both x86_64 and ppc64le these result appears:

github.com/docker/buildx/dap
panic: sync: WaitGroup is reused before previous Wait has returned
goroutine 28 [running]:
sync.(*WaitGroup).Wait(0x45b5d41e2208)
	/usr/lib/golang/src/sync/waitgroup.go:213 +0x198
github.com/docker/buildx/vendor/golang.org/x/sync/errgroup.(*Group).Wait(0x45b5d41e2200)
	/builddir/build/BUILD/docker-buildx-0.32.0-build/buildx-0.32.0/_build/src/github.com/docker/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:56 +0x4c
github.com/docker/buildx/dap.(*Server).Serve.func4()
	/builddir/build/BUILD/docker-buildx-0.32.0-build/buildx-0.32.0/_build/src/github.com/docker/buildx/dap/server.go:61 +0x78
github.com/docker/buildx/vendor/golang.org/x/sync/errgroup.(*Group).Go.func1()
	/builddir/build/BUILD/docker-buildx-0.32.0-build/buildx-0.32.0/_build/src/github.com/docker/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:93 +0x74
created by github.com/docker/buildx/vendor/golang.org/x/sync/errgroup.(*Group).Go in goroutine 24
	/builddir/build/BUILD/docker-buildx-0.32.0-build/buildx-0.32.0/_build/src/github.com/docker/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:78 +0xcc
exit status 2
FAIL	github.com/docker/buildx/dap	0.036s

Complete test results available at: https://koji.fedoraproject.org/koji/taskinfo?taskID=143024149

I have triggered this several times with the same result. However, I have no problems doing a build in a chroot of rawhide on my workstation. Other architectures do not fail.

Potentially related to #3598

Expected behaviour

Successful build

Actual behaviour

Failure in go test as noted. Failure flaky in that it does not occur on all architectures and will succeed on x86_64 workstation but fail on x86_64 builder.

Buildx version

0.32.0

Docker info

n/a error during build

Builders list

n/a error during build

Configuration

n/a

Build logs

https://koji.fedoraproject.org/koji/taskinfo?taskID=143024149

See, for example, https://kojipkgs.fedoraproject.org//work/tasks/4202/143024202/build.log

Additional info

n/a.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions