From 21cc1b25e64aea5faa4004e87a59a056be98636d Mon Sep 17 00:00:00 2001 From: Isaac To Date: Thu, 2 Apr 2026 12:05:41 -0700 Subject: [PATCH] Remove no-op `DANDI_ALLOW_LOCALHOST_URLS` from test configs This variable was consumed by the dandi-archive Django server to permit `localhost` URLs in asset `contentUrl` fields during testing (where assets are stored in a local MinIO instance). It was removed from the test `docker-compose.yml` in commit 09c1b758 when dandi-archive switched to `dandiapi.settings.development`, which handles this by default, making the variable a no-op in the test environment. Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/run-tests.yml | 1 - tox.ini | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 9325829a0..15753f538 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -22,7 +22,6 @@ jobs: runs-on: ${{ matrix.os }} env: NO_ET: 1 - DANDI_ALLOW_LOCALHOST_URLS: "1" DANDI_PAGINATION_DISABLE_FALLBACK: "1" DANDI_TESTS_PERSIST_DOCKER_COMPOSE: "1" strategy: diff --git a/tox.ini b/tox.ini index ffdb9b6e9..16ea23744 100644 --- a/tox.ini +++ b/tox.ini @@ -3,7 +3,6 @@ envlist = lint,typing,py3 [testenv] setenv = - DANDI_ALLOW_LOCALHOST_URLS=1 DANDI_PAGINATION_DISABLE_FALLBACK=1 passenv = DANDI_*,USER,DBUS_SESSION_BUS_ADDRESS extras =