feat(APP-97): Add lock and wrap onboarding dialogs by milosh86 · Pull Request #1019 · aragon/app

milosh86 · 2026-03-10T08:24:41Z

Description

Implements the onboarding dialog flow for the GaugeVoter, TokenVoting and LockToVote plugin's lock or wrap functionality.

Test cases:

Token voting with standard governance token (Only delegation intro should be shown) ✅
Token voting with non-gov token (Wrap intro, then delegation intro) ✅
Token voting with VE IEscrowIVotesAdapter token (Gauges lock intro, then delegation intro) ✅
Standard GaugeVoter plugin (Gauges lock intro, then delegation intro) ✅
Lock to vote (token lock intro, then delegation intro) ✅

Type of Change

Major: Breaking change (change that would cause existing functionality to not work as expected)
Minor: Feature (non-breaking change which adds new functionality)
Patch: Enhancement (non-breaking change to an existing feature)
Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

Review Checklist:

(For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
Confirmed that changes follow the code style guidelines of this project

Signed-off-by: Milos Dzepina <milos@aragon.org>

linear · 2026-03-10T08:24:44Z

APP-97 Lock and wrap onboarding dialogs

github-actions · 2026-03-10T08:27:33Z

🚀 Preview Deployment: View Here

github-actions · 2026-03-10T08:29:20Z

E2E Smoke Results


Base URL	https://app-next-mua22ka6h-aragon-app.vercel.app
Suite	smoke
Result	✅ passed
Run	#3827

Signed-off-by: Milos Dzepina <milos@aragon.org>

* fix: Update XMAQUINA DAO header link Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com> * Update DAO header link for XMAQUINA Update the header link for the XMAQUINA DAO. Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com> --------- Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>

…lugins (#1020) Signed-off-by: Milos Dzepina <milos@aragon.org>

Signed-off-by: Milos Dzepina <milos@aragon.org>

Copilot

Pull request overview

Implements an onboarding dialog flow for lock/wrap scenarios across Token Voting (wrap), Gauge Voter (lock), and Lock-to-Vote (lock), triggered on user-initiated wallet connections.

Changes:

Added a useWalletConnectionEvent hook and updated onboarding watchers to trigger flows on explicit wallet connects.
Introduced new onboarding dialogs (intro/info/form) for GaugeVoter, Token wrap, and LockToVote.
Added onchain “should trigger onboarding” checks (via useReadContracts) plus supporting translations and tests.

Reviewed changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/shared/hooks/useWalletConnectionEvent/useWalletConnectionEvent.ts	New hook to detect non-auto-reconnect wallet connection events.
src/shared/hooks/useWalletConnectionEvent/index.ts	Barrel export for the new hook.
src/plugins/tokenPlugin/utils/tokenPluginUtils/tokenPluginUtils.ts	Adds `getUnderlyingToken` helper for wrapper token UX.
src/plugins/tokenPlugin/utils/tokenPluginUtils/tokenPluginUtils.test.ts	Unit tests for `getUnderlyingToken`.
src/plugins/tokenPlugin/hooks/useTokenLockAndWrapOnboardingCheck/useTokenLockAndWrapOnboardingCheck.ts	New hook to decide whether wrap/lock onboarding should trigger (votes vs underlying balance).
src/plugins/tokenPlugin/hooks/useTokenLockAndWrapOnboardingCheck/useTokenLockAndWrapOnboardingCheck.test.ts	Tests for the new onboarding check hook.
src/plugins/tokenPlugin/hooks/useTokenLockAndWrapOnboardingCheck/useTokenLockAndWrapOnboardingCheck.api.ts	API types for the new hook.
src/plugins/tokenPlugin/hooks/useTokenLockAndWrapOnboardingCheck/index.ts	Barrel export for the new hook.
src/plugins/tokenPlugin/hooks/useOpenDelegationOnboardingIfNeeded/useOpenDelegationOnboardingIfNeeded.ts	Clarifies token address docs (governance vs underlying).
src/plugins/tokenPlugin/dialogs/tokenWrapOnboardingIntroDialog/tokenWrapOnboardingIntroDialog.tsx	New wrap onboarding intro dialog.
src/plugins/tokenPlugin/dialogs/tokenWrapOnboardingIntroDialog/index.ts	Dynamic export for the new dialog.
src/plugins/tokenPlugin/dialogs/tokenWrapOnboardingFormDialog/tokenWrapOnboardingFormDialog.tsx	New wrap onboarding form dialog wrapper around `TokenWrapForm`.
src/plugins/tokenPlugin/dialogs/tokenWrapOnboardingFormDialog/tokenWrapOnboardingFormDialog.api.ts	Dialog params typing.
src/plugins/tokenPlugin/dialogs/tokenWrapOnboardingFormDialog/index.ts	Dynamic export + type export.
src/plugins/tokenPlugin/constants/tokenPluginDialogsDefinitions.ts	Registers new token wrap onboarding dialogs.
src/plugins/tokenPlugin/constants/tokenPluginDialogId.ts	Adds dialog IDs for wrap onboarding intro/form.
src/plugins/tokenPlugin/components/tokenMemberPanel/tokenWrap/tokenWrapForm.tsx	Adds dialog mode rendering (CTA/cancel layout) for wrap form.
src/plugins/tokenPlugin/components/tokenMemberPanel/tokenMemberPanel.tsx	Reuses `getUnderlyingToken` instead of inline symbol/name munging.
src/plugins/tokenPlugin/components/tokenLockAndWrapOnboardingWatcher/tokenLockAndWrapOnboardingWatcher.tsx	New watcher to open GaugeVoter lock onboarding or token wrap onboarding post-connect.
src/plugins/tokenPlugin/components/tokenLockAndWrapOnboardingWatcher/index.ts	Barrel export for new watcher.
src/plugins/tokenPlugin/components/tokenDelegationOnboardingWatcher/tokenDelegationOnboardingWatcher.tsx	Refactors connect-intent logic to use `useWalletConnectionEvent`.
src/plugins/lockToVotePlugin/hooks/useLockToVoteLockOnboardingCheck/useLockToVoteLockOnboardingCheck.ts	New hook to decide whether lock-to-vote onboarding should trigger (locked balance vs token balance).
src/plugins/lockToVotePlugin/hooks/useLockToVoteLockOnboardingCheck/useLockToVoteLockOnboardingCheck.test.ts	Tests for the new lock-to-vote onboarding check hook.
src/plugins/lockToVotePlugin/hooks/useLockToVoteLockOnboardingCheck/useLockToVoteLockOnboardingCheck.api.ts	API types for the new hook.
src/plugins/lockToVotePlugin/hooks/useLockToVoteLockOnboardingCheck/index.ts	Barrel export for the new hook.
src/plugins/lockToVotePlugin/dialogs/lockToVoteLockOnboardingIntroDialog/lockToVoteLockOnboardingIntroDialog.tsx	New lock-to-vote onboarding intro dialog.
src/plugins/lockToVotePlugin/dialogs/lockToVoteLockOnboardingIntroDialog/index.ts	Dynamic export for the new dialog.
src/plugins/lockToVotePlugin/dialogs/lockToVoteLockOnboardingFormDialog/lockToVoteLockOnboardingFormDialog.tsx	New lock-to-vote onboarding form dialog wrapper around `LockToVoteLockForm`.
src/plugins/lockToVotePlugin/dialogs/lockToVoteLockOnboardingFormDialog/lockToVoteLockOnboardingFormDialog.api.ts	Dialog params typing.
src/plugins/lockToVotePlugin/dialogs/lockToVoteLockOnboardingFormDialog/index.ts	Dynamic export + type export.
src/plugins/lockToVotePlugin/constants/lockToVotePluginDialogsDefinitions.ts	Registers new lock-to-vote onboarding dialogs.
src/plugins/lockToVotePlugin/constants/lockToVotePluginDialogId.ts	Adds dialog IDs for lock-to-vote onboarding intro/form.
src/plugins/lockToVotePlugin/components/lockToVoteMemberPanel/lockToVoteLockForm/lockToVoteLockForm.tsx	Adds dialog mode rendering (CTA/cancel layout) for lock form.
src/plugins/lockToVotePlugin/components/lockToVoteLockOnboardingWatcher/lockToVoteLockOnboardingWatcher.tsx	New watcher to trigger lock-to-vote onboarding post-connect.
src/plugins/lockToVotePlugin/components/lockToVoteLockOnboardingWatcher/index.ts	Barrel export for new watcher.
src/plugins/gaugeVoterPlugin/dialogs/gaugeVoterLockOnboardingLockTimeInfoDialog/index.ts	Dynamic export for lock-time info step.
src/plugins/gaugeVoterPlugin/dialogs/gaugeVoterLockOnboardingLockTimeInfoDialog/gaugeVoterLockOnboardingLockTimeInfoDialog.tsx	New lock-time info dialog step in GaugeVoter onboarding flow.
src/plugins/gaugeVoterPlugin/dialogs/gaugeVoterLockOnboardingIntroDialog/index.ts	Dynamic export for GaugeVoter onboarding intro.
src/plugins/gaugeVoterPlugin/dialogs/gaugeVoterLockOnboardingIntroDialog/gaugeVoterLockOnboardingIntroDialog.tsx	New GaugeVoter onboarding intro dialog.
src/plugins/gaugeVoterPlugin/dialogs/gaugeVoterLockOnboardingFormDialog/index.ts	Dynamic export + type export for onboarding form.
src/plugins/gaugeVoterPlugin/dialogs/gaugeVoterLockOnboardingFormDialog/gaugeVoterLockOnboardingFormDialog.tsx	New GaugeVoter onboarding form dialog wrapper around `GaugeVoterLockForm`.
src/plugins/gaugeVoterPlugin/dialogs/gaugeVoterLockOnboardingFormDialog/gaugeVoterLockOnboardingFormDialog.api.ts	Dialog params typing.
src/plugins/gaugeVoterPlugin/constants/gaugeVoterPluginDialogsDefinitions.ts	Registers new GaugeVoter onboarding dialogs.
src/plugins/gaugeVoterPlugin/constants/gaugeVoterPluginDialogId.ts	Adds dialog IDs for GaugeVoter onboarding flow.
src/plugins/gaugeVoterPlugin/components/gaugeVoterLockForm/gaugeVoterLockForm.tsx	Adds dialog mode rendering (CTA/cancel layout) for lock form.
src/modules/application/components/layouts/layoutDao/layoutDao.tsx	Mounts new onboarding watchers at the DAO layout level.
src/modules/application/components/layouts/layoutDao/layoutDao.test.tsx	Mocks new watchers in layout tests.
src/assets/locales/en.json	Adds new translations for onboarding dialogs and cancel labels.
.changeset/app-97-lock-and-wrap-onboarding-dialogs.md	Changeset for releasing the feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T16:48:21Z

...tokenPlugin/components/tokenDelegationOnboardingWatcher/tokenDelegationOnboardingWatcher.tsx

        if (
-            status !== 'connected' ||
-            hasFiredRef.current ||
-            !hasConnectIntentRef.current
+            !hasPendingConnection ||
+            !shouldTrigger ||
+            tokenAddress == null ||
+            tokenSymbol == null


hasPendingConnection is only cleared when the dialog is opened. If the user connects but shouldTrigger is false, the flag stays true and onboarding can open later without a new connection (e.g. after a refetch flips shouldTrigger). Consider consuming/clearing the pending-connection state once the onboarding check has finished (use isLoading from useTokenDelegationOnboardingCheck and clear when !isLoading, regardless of shouldTrigger).

Copilot · 2026-03-11T16:48:22Z

...kenPlugin/components/tokenLockAndWrapOnboardingWatcher/tokenLockAndWrapOnboardingWatcher.tsx

+    useEffect(() => {
+        if (eligiblePlugin == null || !hasPendingConnection || !shouldTrigger) {
+            return;
+        }


hasPendingConnection is only reset when shouldTrigger is true. If the user connects and the check resolves to shouldTrigger=false, the pending flag remains set and the onboarding may open later without a fresh connection. Consider clearing/consuming the pending connection once useTokenLockAndWrapOnboardingCheck is done loading (use the hook’s isLoading and clear when !isLoading).

Copilot · 2026-03-11T16:48:22Z

...kToVotePlugin/components/lockToVoteLockOnboardingWatcher/lockToVoteLockOnboardingWatcher.tsx

+    useEffect(() => {
+        if (
+            lockToVotePlugin == null ||
+            !hasPendingConnection ||
+            !shouldTrigger


hasPendingConnection is only cleared when shouldTrigger is true, so a connect that evaluates to shouldTrigger=false can later trigger onboarding without a new connect (e.g. after refetch). Consider consuming/resetting the pending state once useLockToVoteLockOnboardingCheck has finished loading (use its isLoading).

Copilot · 2026-03-11T16:48:22Z

src/plugins/gaugeVoterPlugin/components/gaugeVoterLockForm/gaugeVoterLockForm.tsx

+            iconRight={mode === 'dialog' ? IconType.CHEVRON_RIGHT : undefined}
+            onClick={effectiveIsConnected ? undefined : () => walletGuard()}
+            size={size}
+            type={effectiveIsConnected ? 'submit' : undefined}


The submit button created by renderSubmitButton no longer sets variant="primary", while the previous inline submit button did. If Button's default variant isn’t primary, this is a UI regression; consider explicitly setting the variant to preserve existing styling.

Suggested change

type={effectiveIsConnected ? 'submit' : undefined}

type={effectiveIsConnected ? 'submit' : undefined}

variant="primary"

milosh86 added 8 commits March 9, 2026 11:45

Implement useWalletConnectionEvent

6f8342a

Signed-off-by: Milos Dzepina <milos@aragon.org>

Update comment

7a295af

Signed-off-by: Milos Dzepina <milos@aragon.org>

Add GaugeVoterLockOnboardingIntroDialog

ea5558a

Signed-off-by: Milos Dzepina <milos@aragon.org>

Implement GaugeVoterLockOnboardingLockTimeInfoDialog

09928d0

Signed-off-by: Milos Dzepina <milos@aragon.org>

Implement GaugeVoterLockOnboardingFormDialog

e3d35c5

Signed-off-by: Milos Dzepina <milos@aragon.org>

Update button order

9911088

Signed-off-by: Milos Dzepina <milos@aragon.org>

Simplify dialog rendering

c64c731

Signed-off-by: Milos Dzepina <milos@aragon.org>

Add changeset

82dadba

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 self-assigned this Mar 10, 2026

milosh86 temporarily deployed to preview March 10, 2026 08:24 — with GitHub Actions Inactive

milosh86 added 2 commits March 10, 2026 09:44

Update changeset msg

1388126

Signed-off-by: Milos Dzepina <milos@aragon.org>

Add wrapping dialogs

8f97603

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview March 10, 2026 13:58 — with GitHub Actions Inactive

Refactor dialog footers into wizard variant

7044bb2

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview March 10, 2026 14:19 — with GitHub Actions Inactive

Add lockToVote onboarding dialogs

21a66e9

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview March 10, 2026 14:49 — with GitHub Actions Inactive

evanaronson and others added 2 commits March 11, 2026 09:38

fix: Correct includeLinkedAccounts param mistakenly named includeSubP…

3056276

…lugins (#1020) Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview March 11, 2026 08:40 — with GitHub Actions Inactive

milosh86 added 2 commits March 11, 2026 10:47

Add lock and wrap watcher component

1e61b88

Signed-off-by: Milos Dzepina <milos@aragon.org>

Fix tests

71ef51f

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview March 11, 2026 09:54 — with GitHub Actions Inactive

milosh86 added 4 commits March 11, 2026 15:59

Address QA issues

55b3e22

Signed-off-by: Milos Dzepina <milos@aragon.org>

Separate LTV into separate watcher

ce8b4bb

Signed-off-by: Milos Dzepina <milos@aragon.org>

Fix type check

3df7186

Signed-off-by: Milos Dzepina <milos@aragon.org>

Fix tests

a2a8dfb

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 had a problem deploying to preview March 11, 2026 16:40 — with GitHub Actions Error

milosh86 marked this pull request as ready for review March 11, 2026 16:41

milosh86 requested a review from a team as a code owner March 11, 2026 16:41

Copilot AI review requested due to automatic review settings March 11, 2026 16:41

Merge branch 'main' into app-97-lock-and-wrap-onboarding-dialogs

cb198b5

milosh86 temporarily deployed to preview March 11, 2026 16:42 — with GitHub Actions Inactive

Copilot started reviewing on behalf of milosh86 March 11, 2026 16:42 View session

milosh86 changed the title ~~feat(APP-97): Add GaugeVoter lock and wrap onboarding dialogs~~ feat(APP-97): Add lock and wrap onboarding dialogs Mar 11, 2026

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(APP-97): Add lock and wrap onboarding dialogs#1019

feat(APP-97): Add lock and wrap onboarding dialogs#1019
milosh86 wants to merge 21 commits intomainfrom
app-97-lock-and-wrap-onboarding-dialogs

milosh86 commented Mar 10, 2026 •

edited

Loading

Uh oh!

linear bot commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	type={effectiveIsConnected ? 'submit' : undefined}
	type={effectiveIsConnected ? 'submit' : undefined}
	variant="primary"

Conversation

milosh86 commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Developer Checklist:

Review Checklist:

Uh oh!

linear bot commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

milosh86 commented Mar 10, 2026 •

edited

Loading

github-actions bot commented Mar 10, 2026 •

edited

Loading

github-actions bot commented Mar 10, 2026 •

edited

Loading