Data2D stores no information about the shape/dimensionality of the data (Trac #622)

[sasview-bot]

The Data2D object currently stores 2D data as three 1D arrays (data, qx_data and qy_data)

This is an issue when it comes to plotting the data, since the 1D data array needs to be converted into a 2D array, but the Data2D object has no information about what shape the 2D array should be.

It's also an issue when it comes to writing NXcanSAS files, since the data is written to the file as a 2D array.

Migrated from http://trac.sasview.org/ticket/622

{
    "status": "closed",
    "changetime": "2016-10-06T16:21:28",
    "_ts": "2016-10-06 16:21:28.610557+00:00",
    "description": "The Data2D object currently stores 2D data as three 1D arrays (data, qx_data and qy_data)\n\nThis is an issue when it comes to plotting the data, since the 1D data array needs to be converted into a 2D array, but the Data2D object has no information about what shape the 2D array should be.\n\nIt's also an issue when it comes to writing NXcanSAS files, since the data is written to the file as a 2D array.",
    "reporter": "lewis",
    "cc": "",
    "resolution": "obsolete",
    "workpackage": "Plotting/Graphing Enhancements",
    "time": "2016-08-18T16:20:16",
    "component": "SasView",
    "summary": "Data2D stores no information about the shape/dimensionality of the data",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.0.0",
    "owner": "",
    "type": "enhancement"
}

[sasview-bot]

Trac update at 2016/08/19 08:43:14: lewis commented:

The Data2D object does actually store information about the shape of the data in x_bins and y_bins, there was just a bug in cansas_reader_HDF5.py that x_bins and y_bins weren't being set.

However, there is still an issue that !PlotPanel.py doesn't seem to know about these properties, so creates it's own bins based on the assumption that the data is square.

[smk78]

Trac update at 2016/08/19 10:05:27: smk78 commented:

Also, when we looked yesterday with Andrew, it wasn't clear that DataInfo was being fed the size/shape.

[sasview-bot]

Trac update at 2016/08/19 13:00:17: Lewis O'Driscoll <lewis.o'drisco commented:

In [a4deca6]:

#!CommitTicketReference repository="" revision="a4deca600c233c866bddf97395879f4fcd0758af"
Set data.x_bins and data.y_bins in CanSAS 2.0 reader (references #754)

[sasview-bot]

Trac update at 2016/08/19 13:08:17:

• lewis changed _comment0 from "The shape of the data can be figured out from the length of x_bins and y_bins" to "1471612163367785"
• lewis changed _comment1 from "" to "1471612339931476"
• lewis commented:

Replying to [comment:2 smk78]:

Also, when we looked yesterday with Andrew, it wasn't clear that DataInfo was being fed the size/shape.

Data Info can figure out the shape of the data from the lengths of x_bins and y_bins, it just doesn't display this to the user

[sasview-bot]

Trac update at 2016/08/19 13:28:38:

• lewis commented:

Opened ticket #755 re: Steve's comment

• lewis changed resolution from "" to "obsolete"
• lewis changed status from "new" to "closed"

[sasview-bot]

Trac update at 2016/10/06 16:21:28: lewis commented:

In changeset ac370c5:

#!CommitTicketReference repository="sasview" revision="ac370c578560050761b9b991a608df5a849588be"
Set data.x_bins and data.y_bins in CanSAS 2.0 reader (references #754)