Satochip multisig crash

[cakesoft-vaibhav]

Describe the bug
Upgraded app crashes on selecting satochip in multisig wallet creation flow.

To Reproduce
Steps to reproduce the behavior:

1. Install build 2.5.8
2. Add satochip signer
3. Upgrade app to version 2.5.9
4. Create multisig wallet with satochip.

Expected behavior
Wallet should have created successfully,

Actual Behaviour
App crashes on selecting satochip signer on signer selection screen for multisig vault.
(Production app on mainnet)

Screenshots

[Bastien-Satochip]

Creation of the Satochip key in the previous version was buggy.
If you delete the Satochip key and create it again. Do you still experience such crash ?

I've througly tested the version 2.5.9 - single sig and multi-sig setup without any issue.

[Toporin]

The initial issue was caused by the wrong xpub format generated during Satochip signer creation in version 2.5.8. The issue was patched in version 2.5.9, but if a Satochip signer was created in v2.5.8, it still persists in v2.5.9 with the wrong format.

To fully clear the issue for existing keys with wrong xpub format, the user can manually remove the key and reimport it in the patched version of the app. Another option could be to catch the exception and display to user an instruction to remove the defective signer.

Alternatively, the signer database can be migrated to ensure that any Satochip xpub in the wrong format is converted in the correct format, using runRealmMigrations(). This should be transparent for the user.
I can submit a PR implementing this approach. Let me know if this would this be an acceptable solution?

[damko]

I have the same issue as OP. @Toporin kindly, where can I find version 2.5.9 ? in /releases I only see 2.5.8

[damko]

nevermind, I understood #6909

waiting impatiently :-)

[cakesoft-vaibhav]

https://github.com/KeeperCommunity/bitcoin-keeper/releases/tag/v2.5.9

[damko]

I <3 you!!!!

[damko]

It works beautifully!