numbered socklist params are not parsed properly if in the wrong order

[roysmith]

See https://en.wikipedia.org/w/index.php?title=Wikipedia:Sockpuppet_investigations/BasedHistorian_PHD&oldid=1163548470

{{sock list|1=Fabrazio224|tools_link=yes|note1=({{clerknote}} original case name)|2=DrNiko giannispolous|3=Havenzeye|4=Kingarthurix}}

spihelper only sees the Fabrazio224 sock. When I rearranged the order, it found them all. I don't know if technically this is legal wiki syntax or not, but it's worth seeing if it can be handled gracefully.

[SirSputnikWiki]

With a bit of testing, I've at least figured out what the problem is here. The regex that parses the sock list is not set up to deal with nested templates. It reads the braces that end the clerknote template as denoting the end of the sock list.

[roysmith]

Thanks for looking into that. As a general rule, I really try to avoid using regex for parsing. It's a losing game of finding problems like this. In Python code, I use https://mwparserfromhell.readthedocs.io/, or you can use https://www.mediawiki.org/wiki/Parsoid from javascript. Not that I expect it's worth the effort to retrofit that into the existing code.

…

On Jun 22, 2024, at 1:08 PM, SirSputnikWiki ***@***.***> wrote: With a bit of testing, I've at least figured out what the problem is here. The regex that parses the sock list is not set up to deal with nested templates. It reads the braces that end the clerknote template as denoting the end of the sock list. — Reply to this email directly, view it on GitHub <#151 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFL6UOV2C3AKGONYZUVTSLZIWVPFAVCNFSM6AAAAABJXSTGUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUGEYTEMBUHA>. You are receiving this because you authored the thread.