Increase Unit Test Coverage >= 90%

[kb1lqc]

We currently have about 79% coverage for a unit test. Let's bring that test coverage above 90%!

Coveralls Data

https://coveralls.io/github/FaradayRF/faradayio?branch=master

Files to Test

• https://github.com/FaradayRF/faradayio/blob/master/faradayio/faraday.py

Unit Test Files

• https://github.com/FaradayRF/faradayio/blob/master/tests/test_serial.py
• https://github.com/FaradayRF/faradayio/blob/master/tests/test_tun.py

Coverage Report Generation

We use coveralls-python to generate coverage reports. The .coveragerc file defines that we only test the module faradayio and our travis.yml file specifies the coverage test on line 11

The issue ticket documenting adding unit test coverage with coveralls is #30 which could be of help when working with the tools.

[kb1lqc]

An observation: Unit Testing the run() function could automatically test the monitorTUN() function as well.

https://coveralls.io/builds/15714182/source?filename=faradayio/faraday.py#L217

[kb1lqc]

@hdkmike, @reillyeon, @nedbat I'm seeing odd operation of coverage

https://coveralls.io/builds/15752681/source?filename=faradayio/faraday.py

The above coverage report agrees with my local use of coverage. It's pretty clear that the run() code is not being included in the coverage test output. This is odd because I am using --concurrancy=thread and also using the Threading.thread module as the documentation suggests.

I also attempted to use --timid with no effect.

• Heck, this appears to be an environment specific issue per coveragepy #582

I'm at a loss here. I will probably remove this ticket from the current project and keep it on the backburner. It may even make me look at asyncio again now that the TUN code is working.