"Disable" button in the mod list gui seems always in a wrong state #516
Description
Your CleanroomMC Discord Username
RuiXuqi
Cleanroom Version
0.3.33-alpha
Java Version
Java 25
Graphics Card Vendor
Intel iGPU
Bug Report
For mods utilizing net.minecraftforge.fml.common.Mod annotation, canBeDeactivated() returns false by default.
However, the "Disable" button in GuiModList remains consistently enabled in-game for these mods. While the implementation correctly handles the enabled state for certain special mod containers, it fails to do so for standard @Mod mods. Although runtime deactivation is a niche Forge feature, this inconsistency leads to an incorrect UI state where a non-deactivatable mod appears as if it could be disabled.
GuiModList seems not faulty. Maybe the issue lies in canBeDisabled() implementations.
Mod List
Example:
Fugue uses @Mod without overdding canBeDeactivated() true, but "Disable" is enabled.
Forge uses a special container, and "Disable" is disabled properly.
Final Checklist
- I have searched the issues and haven't found a similar issue.
- I have read the readme and know that what is action build.
- I have installed Fugue and it didn't fix my issue.
- I have installed Scalar Legacy and it didn't fix my issue.
- I have switched my Forgelin and LibrarianLib to continuous versions(check readme for more detail).
- I am running a test build from Cleanroom Github Actions. (Or, if I've compiled it myself I plan to fix the issue)
- I did not use PCL/PCLCE or other unsupported launchers.
我没有使用 PCL/PCLCE 等其他未被支持的启动器。