Skip to content

Roof direction check for skillion #60

@justinormont

Description

@justinormont

The !this.options.roof.direction should instead check for null/undefined:

if (this.options.roof.shape === 'skillion' && !this.options.roof.direction) {

In JavaScript, 0 is nullish, causing this warning to be printed, if you set the direction of a skillion roof to 0 (north-facing roof).

Expected behavior:

Since 0 is an acceptable roof direction, no warning should be printed.

Impact:

Minor, since I think it only causes a warning.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions